Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

branch-3.0: [fix](nereids)should set isForwardedToMaster and redirectStatus to null before fallback to legacy planner #44163 #44237

Closed
wants to merge 1 commit into from
Closed

branch-3.0: [fix](nereids)should set isForwardedToMaster and redirectStatus to null before fallback to legacy planner #44163 #44237

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link
Contributor

Cherry-picked from #44163

@starocean999
[fix](nereids)should set isForwardedToMaster and redirectStatus to nu…
f37cf9e 
…ll before fallback to legacy planner (#44163)

Problem Summary:
when fallback to legacy planner, we need legacy planner to decide if the
sql needs to be forwarded to master. But legacy planner doesn't work if
isForwardedToMaster is already set to non-null value. So we should set
isForwardedToMaster and redirectStatus to null before fallback
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Nov 19, 2024
@doris-robot
Copy link

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 43224 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f37cf9e52dd87ae944750576cd7b8a95c49511c0, data reload: false

------ Round 1 ----------------------------------
q1	17634	7577	7345	7345
q2	2065	161	161	161
q3	10732	1072	1099	1072
q4	10550	792	769	769
q5	7731	3038	2844	2844
q6	234	148	148	148
q7	979	610	620	610
q8	9359	1954	2042	1954
q9	6557	6407	6411	6407
q10	6944	2305	2305	2305
q11	454	258	253	253
q12	406	214	212	212
q13	17767	2954	2960	2954
q14	241	211	220	211
q15	560	522	538	522
q16	663	601	597	597
q17	979	549	572	549
q18	7270	6591	6582	6582
q19	3373	1059	1022	1022
q20	2938	2652	2652	2652
q21	3954	3112	3153	3112
q22	1101	943	991	943
Total cold run time: 112491 ms
Total hot run time: 43224 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7387	7327	7419	7327
q2	344	239	243	239
q3	3053	2899	2941	2899
q4	2048	1840	1751	1751
q5	5656	5770	5804	5770
q6	222	142	140	140
q7	2149	1781	1779	1779
q8	3206	3494	3499	3494
q9	8981	8798	8879	8798
q10	3549	3508	3558	3508
q11	593	493	509	493
q12	818	619	598	598
q13	16536	3092	3138	3092
q14	318	271	279	271
q15	568	538	528	528
q16	724	676	666	666
q17	1893	1647	1627	1627
q18	8166	7762	7592	7592
q19	3163	1524	1601	1524
q20	2015	1896	1822	1822
q21	5409	5214	5237	5214
q22	1107	1018	990	990
Total cold run time: 77905 ms
Total hot run time: 60122 ms

@morrySnow morrySnow closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@doris-robot @dataroaring @morrySnow @starocean999